testlibrbd: fix assert side effect

Coverity cid 1, 2

Signed-off-by: Sage Weil <sage@newdream.net>

diff --git a/src/testlibrbd.c b/src/testlibrbd.c
index 1290d24691a6a62d6c9e15be1aa0c70f9a5b2b2e..348d5213d09569dac090121b1b2b80e5bf8d5f39 100644 (file)
--- a/src/testlibrbd.c
+++ b/src/testlibrbd.c
@@ -193,9 +193,9 @@ void write_test_data(rbd_image_t image, const char *test_data, uint64_t off, siz
 void aio_read_test_data(rbd_image_t image, const char *expected, uint64_t off, size_t len)
 {
   rbd_completion_t comp;
-  char *result;
-  assert((result = malloc(sizeof(result) * (len + 1))) != 0);
+  char *result = malloc(sizeof(result) * (len + 1));
 
+  assert(result);
   rbd_aio_create_completion(NULL, (rbd_callback_t) simple_read_cb, &comp);
   printf("created completion\n");
   rbd_aio_read(image, off, len, result, comp);
@@ -213,9 +213,9 @@ void aio_read_test_data(rbd_image_t image, const char *expected, uint64_t off, s
 void read_test_data(rbd_image_t image, const char *expected, uint64_t off, size_t len)
 {
   ssize_t read;
-  char *result;
-  assert((result = malloc(sizeof(result) * (len + 1))) != 0);
+  char *result = malloc(sizeof(result) * (len + 1));
 
+  assert(result);
   read = rbd_read(image, off, len, result);
   printf("read: %d\n", (int) read);
   assert(read == (ssize_t)len);