]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/dashboard: fix rgw port manipulation error in dashboard 53392/head
authorNizamudeen A <nia@redhat.com>
Thu, 7 Sep 2023 08:15:00 +0000 (13:45 +0530)
committerNizamudeen A <nia@redhat.com>
Mon, 11 Sep 2023 11:57:33 +0000 (17:27 +0530)
Fixes: https://tracker.ceph.com/issues/62735
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 9529163d29ab2d7fdb1e20b4066196dbb838917f)

src/pybind/mgr/dashboard/controllers/rgw.py
src/pybind/mgr/dashboard/tests/test_rgw.py

index 766c8eadc51e5e0dfce117ab8d6dab5c2877c196..67c7cbca26d32cc6b1dc8fb2d5a1f73c54f4ceee 100644 (file)
@@ -2,6 +2,7 @@
 
 import json
 import logging
+import re
 from typing import Any, Dict, List, NamedTuple, Optional, Union
 
 import cherrypy
@@ -143,7 +144,7 @@ class RgwDaemon(RESTController):
                     'zonegroup_name': metadata['zonegroup_name'],
                     'zone_name': metadata['zone_name'],
                     'default': instance.daemon.name == metadata['id'],
-                    'port': int(metadata['frontend_config#0'].split('port=')[1])
+                    'port': int(re.findall(r'port=(\d+)', metadata['frontend_config#0'])[0])
                 }
 
                 daemons.append(daemon)
index 33b5ecb6cf90936ad57d1a0860302f4cdcf8b0c3..bfb1dbc70355a0e4b765a7cd81e4317cbf6fabcc 100644 (file)
@@ -96,7 +96,7 @@ class RgwDaemonControllerTestCase(ControllerTestCase):
                 'realm_name': 'realm2',
                 'zonegroup_name': 'zg2',
                 'zone_name': 'zone2',
-                'frontend_config#0': 'beast port=80'
+                'frontend_config#0': 'beast port=80 ssl_port=443 ssl_certificate=config:/config'
             }]
         self._get('/test/api/rgw/daemon')
         self.assertStatus(200)