]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
cephadm: make bootstrap default to "global" section for public_network setting 59957/head
authorAdam King <adking@redhat.com>
Tue, 24 Sep 2024 16:16:14 +0000 (12:16 -0400)
committerAdam King <adking@redhat.com>
Tue, 24 Sep 2024 16:16:14 +0000 (12:16 -0400)
Fixes: https://tracker.ceph.com/issues/68212
Signed-off-by: Adam King <adking@redhat.com>
src/cephadm/cephadm.py

index 1ab98a0ac4f1ea821a2cfd6fa63dd57a151c7971..135d50dc5f94e842746f74b6291fe24dfbb69be1 100755 (executable)
@@ -1986,11 +1986,15 @@ def get_image_info_from_inspect(out, image):
 def get_public_net_from_cfg(ctx: CephadmContext) -> Optional[str]:
     """Get mon public network from configuration file."""
     cp = read_config(ctx.config)
-    if not cp.has_option('global', 'public_network'):
+    public_network = ''
+    if cp.has_option('mon', 'public_network'):
+        public_network = cp.get('mon', 'public_network').strip('"').strip("'")
+    elif cp.has_option('global', 'public_network'):
+        public_network = cp.get('global', 'public_network').strip('"').strip("'")
+    else:
         return None
 
     # Ensure all public CIDR networks are valid
-    public_network = cp.get('global', 'public_network').strip('"').strip("'")
     rc, _, err_msg = check_subnet(public_network)
     if rc:
         raise Error(f'Invalid public_network {public_network} parameter: {err_msg}')
@@ -2595,7 +2599,7 @@ def finish_bootstrap_config(
 
     if mon_network:
         cp = read_config(ctx.config)
-        cfg_section = 'global' if cp.has_option('global', 'public_network') else 'mon'
+        cfg_section = 'mon' if cp.has_option('mon', 'public_network') else 'global'
         logger.info(f'Setting public_network to {mon_network} in {cfg_section} config section')
         cli(['config', 'set', cfg_section, 'public_network', mon_network])