]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
Revert "c_read_operations.cc: fix resource leak"
authorDavid Zafman <david.zafman@inktank.com>
Wed, 5 Mar 2014 23:08:41 +0000 (15:08 -0800)
committerDavid Zafman <david.zafman@inktank.com>
Wed, 5 Mar 2014 23:13:55 +0000 (15:13 -0800)
This reverts commit 3cd751b0a280909510c3e633cc8cd4b9f5e3b2d9.

A rados_release_read_op() has already been performed, but coverity
didn't recognize that as releasing memory.

Fixes: #7621
Signed-off-by: David Zafman <david.zafman@inktank.com>
Reviewed-by: Samuel Just <sam.just@inktank.com>
src/test/librados/c_read_operations.cc

index 053b6147ba511b64eabca63bea20e95bd352ad44..106f6b4f162d99e36f5641da4393d2e1025117a3 100644 (file)
@@ -365,7 +365,6 @@ TEST_F(CReadOpsTest, ExecUserBuf) {
 
   // buffer too short
   bytes_read = 1024;
-  rados_release_read_op(op);
   op = rados_create_read_op();
   rados_read_op_exec_user_buf(op, "rbd", "get_all_features", NULL, 0, out,
                              sizeof(features) - 1, &bytes_read, &rval);