]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
client: remove redundant check
authorPatrick Donnelly <pdonnell@ibm.com>
Wed, 19 Feb 2025 16:32:06 +0000 (11:32 -0500)
committerPatrick Donnelly <pdonnell@ibm.com>
Thu, 27 Feb 2025 18:41:55 +0000 (13:41 -0500)
This condition:

    (!dn->inode || dn->inode->caps_issued_mask(mask, true))

is already checked in the surrounding `if`.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
src/client/Client.cc

index c45e8c1a5082fa01932fafce7a0e143c04d9737a..68bce32682c796d6b0582b98bc06317f0b7b1e72 100644 (file)
@@ -7413,9 +7413,9 @@ relookup:
       }
       // dir shared caps?
       if (dir->caps_issued_mask(CEPH_CAP_FILE_SHARED, true)) {
-       if (dn->cap_shared_gen == dir->shared_gen &&
-           (!dn->inode || dn->inode->caps_issued_mask(mask, true)))
-             goto hit_dn;
+       if (dn->cap_shared_gen == dir->shared_gen) {
+         goto hit_dn;
+        }
        if (!dn->inode && (dir->flags & I_COMPLETE)) {
          ldout(cct, 10) << __func__ << " concluded ENOENT locally for "
                         << *dir << " dn '" << dname << "'" << dendl;