]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
librbd: remove unused member in FlattenRequest 19416/head
authorMykola Golub <to.my.trociny@gmail.com>
Sat, 9 Dec 2017 09:40:13 +0000 (11:40 +0200)
committerMykola Golub <to.my.trociny@gmail.com>
Sat, 9 Dec 2017 09:47:01 +0000 (11:47 +0200)
Signed-off-by: Mykola Golub <to.my.trociny@gmail.com>
src/librbd/Operations.cc
src/librbd/operation/FlattenRequest.cc
src/librbd/operation/FlattenRequest.h

index 393a8b2d7c80a212ea570ddd34b41cb5293aee99..4d71e3d319b5a6e240a0f7fc0723f945e79eb12a 100644 (file)
@@ -405,16 +405,15 @@ void Operations<I>::execute_flatten(ProgressContext &prog_ctx,
   assert(r == 0);
   assert(overlap <= m_image_ctx.size);
 
-  uint64_t object_size = m_image_ctx.get_object_size();
-  uint64_t  overlap_objects = Striper::get_num_objects(m_image_ctx.layout,
-                                                       overlap);
+  uint64_t overlap_objects = Striper::get_num_objects(m_image_ctx.layout,
+                                                      overlap);
 
   m_image_ctx.parent_lock.put_read();
   m_image_ctx.snap_lock.put_read();
 
   operation::FlattenRequest<I> *req = new operation::FlattenRequest<I>(
-    m_image_ctx, new C_NotifyUpdate<I>(m_image_ctx, on_finish), object_size,
-    overlap_objects, snapc, prog_ctx);
+    m_image_ctx, new C_NotifyUpdate<I>(m_image_ctx, on_finish), overlap_objects,
+    snapc, prog_ctx);
   req->send();
 }
 
index c9d912fc15bbdb0dd01a9b9615d56f2d42b75002..a1d88f0451f08da3ecd4df638db968c08227b6d8 100644 (file)
@@ -22,10 +22,9 @@ template <typename I>
 class C_FlattenObject : public C_AsyncObjectThrottle<I> {
 public:
   C_FlattenObject(AsyncObjectThrottle<I> &throttle, I *image_ctx,
-                  uint64_t object_size, ::SnapContext snapc, uint64_t object_no)
-    : C_AsyncObjectThrottle<I>(throttle, *image_ctx), m_object_size(object_size),
-      m_snapc(snapc), m_object_no(object_no)
-  {
+                  ::SnapContext snapc, uint64_t object_no)
+    : C_AsyncObjectThrottle<I>(throttle, *image_ctx), m_snapc(snapc),
+      m_object_no(object_no) {
   }
 
   int send() override {
@@ -55,7 +54,6 @@ public:
   }
 
 private:
-  uint64_t m_object_size;
   ::SnapContext m_snapc;
   uint64_t m_object_no;
 };
@@ -105,8 +103,7 @@ void FlattenRequest<I>::send_op() {
   m_state = STATE_FLATTEN_OBJECTS;
   typename AsyncObjectThrottle<I>::ContextFactory context_factory(
     boost::lambda::bind(boost::lambda::new_ptr<C_FlattenObject<I> >(),
-      boost::lambda::_1, &image_ctx, m_object_size, m_snapc,
-      boost::lambda::_2));
+      boost::lambda::_1, &image_ctx, m_snapc, boost::lambda::_2));
   AsyncObjectThrottle<I> *throttle = new AsyncObjectThrottle<I>(
     this, image_ctx, context_factory, this->create_callback_context(), &m_prog_ctx,
     0, m_overlap_objects);
index 1035a141e299c8f76bebed5a65a7b7552f0c9986..f64a043ab55a4c901f5615abeacf4a4960bd45e4 100644 (file)
@@ -19,12 +19,10 @@ class FlattenRequest : public Request<ImageCtxT>
 {
 public:
   FlattenRequest(ImageCtxT &image_ctx, Context *on_finish,
-                uint64_t object_size, uint64_t overlap_objects,
-                const ::SnapContext &snapc, ProgressContext &prog_ctx)
-    : Request<ImageCtxT>(image_ctx, on_finish), m_object_size(object_size),
-      m_overlap_objects(overlap_objects), m_snapc(snapc), m_prog_ctx(prog_ctx),
-      m_ignore_enoent(false)
-  {
+                 uint64_t overlap_objects, const ::SnapContext &snapc,
+                 ProgressContext &prog_ctx)
+    : Request<ImageCtxT>(image_ctx, on_finish), m_overlap_objects(overlap_objects),
+      m_snapc(snapc), m_prog_ctx(prog_ctx) {
   }
 
 protected:
@@ -69,14 +67,13 @@ private:
     STATE_UPDATE_CHILDREN
   };
 
-  uint64_t m_object_size;
   uint64_t m_overlap_objects;
   ::SnapContext m_snapc;
   ProgressContext &m_prog_ctx;
   State m_state = STATE_FLATTEN_OBJECTS;
 
   ParentSpec m_parent_spec;
-  bool m_ignore_enoent;
+  bool m_ignore_enoent = false;
 
   bool send_update_header();
   bool send_update_children();