]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/dashboard: pylint: reduce number of branches 35521/head
authorSebastian Wagner <sebastian.wagner@suse.com>
Wed, 10 Jun 2020 13:40:34 +0000 (15:40 +0200)
committerSebastian Wagner <sebastian.wagner@suse.com>
Wed, 10 Jun 2020 13:43:54 +0000 (15:43 +0200)
fixes: `R0912: Too many branches (14/12) (too-many-branches)`
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
src/pybind/mgr/dashboard/controllers/mgr_modules.py

index d296d17fbf3f057c77a15e558bfcf47e1731b974..0d4cc5222560c54a9708a654212d11cd35dea42d 100644 (file)
@@ -158,16 +158,13 @@ class MgrModules(RESTController):
                 else:
                     option['default_value'] = str_to_bool(
                         option['default_value'])
-            elif option['type'] == 'float':
+            elif option['type'] in ['float', 'uint', 'int', 'size', 'secs']:
+                cls = {
+                    'float': float
+                }.get(option['type'], int)
                 for name in ['default_value', 'min', 'max']:
                     if option[name] == 'None':  # This is Python None
                         option[name] = None
                     elif option[name]:  # Skip empty entries
-                        option[name] = float(option[name])
-            elif option['type'] in ['uint', 'int', 'size', 'secs']:
-                for name in ['default_value', 'min', 'max']:
-                    if option[name] == 'None':  # This is Python None
-                        option[name] = None
-                    elif option[name]:  # Skip empty entries
-                        option[name] = int(option[name])
+                        option[name] = cls(option[name])
         return options