]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/osd: print notify_id instead of its address
authorKefu Chai <kchai@redhat.com>
Wed, 9 Sep 2020 03:46:01 +0000 (11:46 +0800)
committerKefu Chai <kchai@redhat.com>
Wed, 9 Sep 2020 05:27:25 +0000 (13:27 +0800)
this addresses the FTBFS like

    /usr/include/fmt/core.h:902:19: error: static assertion failed: formatting of non-void pointers is disallowed
      902 |     static_assert(!sizeof(T), "formatting of non-void pointers is disallowed");
          |                   ^~~~~~~~~~

also, i think it is more helpful in this context to have the
notify id instead of the address, as we can use the id to reference
the notification printed by other logging messages.

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/crimson/osd/watch.cc

index 68eea9277d71ad6037f12d5eb77d238e7789c000..a7a3311aa9b6c3a5321e247c524fc55aa131f96c 100644 (file)
@@ -44,7 +44,7 @@ seastar::future<> Watch::send_notify_msg(NotifyRef notify)
 
 seastar::future<> Watch::start_notify(NotifyRef notify)
 {
-  logger().info("{} adding &notify={}", __func__, notify.get());
+  logger().info("{} adding notify(id={})", __func__, notify->ninfo.notify_id);
   auto [ it, emplaced ] = in_progress_notifies.emplace(std::move(notify));
   ceph_assert(emplaced);
   ceph_assert(is_alive());