rbd: fix usage for snap commands

Snap commands take '--snap <snapname> <imagename>'.

Signed-off-by: Sage Weil <sage@inktank.com>

diff --git a/src/rbd.cc b/src/rbd.cc
index 020071db3ae7e60509606fd2d2c733381085477f..4e34f1f0fb0be545889e034124bc8d6a790922d1 100644 (file)
--- a/src/rbd.cc
+++ b/src/rbd.cc
@@ -81,9 +81,10 @@ void usage()
 "  (cp | copy) <src> <dest>                    copy src image to dest\n"
 "  (mv | rename) <src> <dest>                  rename src image to dest\n"
 "  snap ls <image-name>                        dump list of image snapshots\n"
-"  snap create <snap-name>                     create a snapshot\n"
-"  snap rollback <snap-name>                   rollback image to snapshot\n"
-"  snap rm <snap-name>                         deletes a snapshot\n"
+"  snap create --snap <snap-name> <image-name> create a snapshot\n"
+"  snap rollback --snap <snap-name> <image-name>\n"
+"                                              rollback image to snapshot\n"
+"  snap rm --snap <snap-name> <image-name>     deletes a snapshot\n"
 "  snap purge <image-name>                     deletes all snapshots\n"
 "  watch <image-name>                          watch events on image\n"
 "  map <image-name>                            map image to a block device\n"

diff --git a/src/test/cli/rbd/help.t b/src/test/cli/rbd/help.t
index a7c1a126eeb0ca3b55087fb431c9cb0d32efb045..d44d1db024111f0bd6b64225d1b576ea5c2c4775 100644 (file)
--- a/src/test/cli/rbd/help.t
+++ b/src/test/cli/rbd/help.t
@@ -17,9 +17,10 @@
     (cp | copy) <src> <dest>                    copy src image to dest
     (mv | rename) <src> <dest>                  rename src image to dest
     snap ls <image-name>                        dump list of image snapshots
-    snap create <snap-name>                     create a snapshot
-    snap rollback <snap-name>                   rollback image to snapshot
-    snap rm <snap-name>                         deletes a snapshot
+    snap create --snap <snap-name> <image-name> create a snapshot
+    snap rollback --snap <snap-name> <image-name>
+                                                rollback image to snapshot
+    snap rm --snap <snap-name> <image-name>     deletes a snapshot
     snap purge <image-name>                     deletes all snapshots
     watch <image-name>                          watch events on image
     map <image-name>                            map image to a block device

diff --git a/src/test/cli/rbd/invalid-snap-usage.t b/src/test/cli/rbd/invalid-snap-usage.t
index 63157bfbb7151e4fff82751af2a132ab1062d1f3..7669ed4fc261a76867bec218a5d0e7af63fb7074 100644 (file)
--- a/src/test/cli/rbd/invalid-snap-usage.t
+++ b/src/test/cli/rbd/invalid-snap-usage.t
@@ -18,9 +18,10 @@
     (cp | copy) <src> <dest>                    copy src image to dest
     (mv | rename) <src> <dest>                  rename src image to dest
     snap ls <image-name>                        dump list of image snapshots
-    snap create <snap-name>                     create a snapshot
-    snap rollback <snap-name>                   rollback image to snapshot
-    snap rm <snap-name>                         deletes a snapshot
+    snap create --snap <snap-name> <image-name> create a snapshot
+    snap rollback --snap <snap-name> <image-name>
+                                                rollback image to snapshot
+    snap rm --snap <snap-name> <image-name>     deletes a snapshot
     snap purge <image-name>                     deletes all snapshots
     watch <image-name>                          watch events on image
     map <image-name>                            map image to a block device
@@ -68,9 +69,10 @@
     (cp | copy) <src> <dest>                    copy src image to dest
     (mv | rename) <src> <dest>                  rename src image to dest
     snap ls <image-name>                        dump list of image snapshots
-    snap create <snap-name>                     create a snapshot
-    snap rollback <snap-name>                   rollback image to snapshot
-    snap rm <snap-name>                         deletes a snapshot
+    snap create --snap <snap-name> <image-name> create a snapshot
+    snap rollback --snap <snap-name> <image-name>
+                                                rollback image to snapshot
+    snap rm --snap <snap-name> <image-name>     deletes a snapshot
     snap purge <image-name>                     deletes all snapshots
     watch <image-name>                          watch events on image
     map <image-name>                            map image to a block device
@@ -118,9 +120,10 @@
     (cp | copy) <src> <dest>                    copy src image to dest
     (mv | rename) <src> <dest>                  rename src image to dest
     snap ls <image-name>                        dump list of image snapshots
-    snap create <snap-name>                     create a snapshot
-    snap rollback <snap-name>                   rollback image to snapshot
-    snap rm <snap-name>                         deletes a snapshot
+    snap create --snap <snap-name> <image-name> create a snapshot
+    snap rollback --snap <snap-name> <image-name>
+                                                rollback image to snapshot
+    snap rm --snap <snap-name> <image-name>     deletes a snapshot
     snap purge <image-name>                     deletes all snapshots
     watch <image-name>                          watch events on image
     map <image-name>                            map image to a block device
@@ -168,9 +171,10 @@
     (cp | copy) <src> <dest>                    copy src image to dest
     (mv | rename) <src> <dest>                  rename src image to dest
     snap ls <image-name>                        dump list of image snapshots
-    snap create <snap-name>                     create a snapshot
-    snap rollback <snap-name>                   rollback image to snapshot
-    snap rm <snap-name>                         deletes a snapshot
+    snap create --snap <snap-name> <image-name> create a snapshot
+    snap rollback --snap <snap-name> <image-name>
+                                                rollback image to snapshot
+    snap rm --snap <snap-name> <image-name>     deletes a snapshot
     snap purge <image-name>                     deletes all snapshots
     watch <image-name>                          watch events on image
     map <image-name>                            map image to a block device
@@ -218,9 +222,10 @@
     (cp | copy) <src> <dest>                    copy src image to dest
     (mv | rename) <src> <dest>                  rename src image to dest
     snap ls <image-name>                        dump list of image snapshots
-    snap create <snap-name>                     create a snapshot
-    snap rollback <snap-name>                   rollback image to snapshot
-    snap rm <snap-name>                         deletes a snapshot
+    snap create --snap <snap-name> <image-name> create a snapshot
+    snap rollback --snap <snap-name> <image-name>
+                                                rollback image to snapshot
+    snap rm --snap <snap-name> <image-name>     deletes a snapshot
     snap purge <image-name>                     deletes all snapshots
     watch <image-name>                          watch events on image
     map <image-name>                            map image to a block device
@@ -268,9 +273,10 @@
     (cp | copy) <src> <dest>                    copy src image to dest
     (mv | rename) <src> <dest>                  rename src image to dest
     snap ls <image-name>                        dump list of image snapshots
-    snap create <snap-name>                     create a snapshot
-    snap rollback <snap-name>                   rollback image to snapshot
-    snap rm <snap-name>                         deletes a snapshot
+    snap create --snap <snap-name> <image-name> create a snapshot
+    snap rollback --snap <snap-name> <image-name>
+                                                rollback image to snapshot
+    snap rm --snap <snap-name> <image-name>     deletes a snapshot
     snap purge <image-name>                     deletes all snapshots
     watch <image-name>                          watch events on image
     map <image-name>                            map image to a block device
@@ -318,9 +324,10 @@
     (cp | copy) <src> <dest>                    copy src image to dest
     (mv | rename) <src> <dest>                  rename src image to dest
     snap ls <image-name>                        dump list of image snapshots
-    snap create <snap-name>                     create a snapshot
-    snap rollback <snap-name>                   rollback image to snapshot
-    snap rm <snap-name>                         deletes a snapshot
+    snap create --snap <snap-name> <image-name> create a snapshot
+    snap rollback --snap <snap-name> <image-name>
+                                                rollback image to snapshot
+    snap rm --snap <snap-name> <image-name>     deletes a snapshot
     snap purge <image-name>                     deletes all snapshots
     watch <image-name>                          watch events on image
     map <image-name>                            map image to a block device
@@ -368,9 +375,10 @@
     (cp | copy) <src> <dest>                    copy src image to dest
     (mv | rename) <src> <dest>                  rename src image to dest
     snap ls <image-name>                        dump list of image snapshots
-    snap create <snap-name>                     create a snapshot
-    snap rollback <snap-name>                   rollback image to snapshot
-    snap rm <snap-name>                         deletes a snapshot
+    snap create --snap <snap-name> <image-name> create a snapshot
+    snap rollback --snap <snap-name> <image-name>
+                                                rollback image to snapshot
+    snap rm --snap <snap-name> <image-name>     deletes a snapshot
     snap purge <image-name>                     deletes all snapshots
     watch <image-name>                          watch events on image
     map <image-name>                            map image to a block device
@@ -418,9 +426,10 @@
     (cp | copy) <src> <dest>                    copy src image to dest
     (mv | rename) <src> <dest>                  rename src image to dest
     snap ls <image-name>                        dump list of image snapshots
-    snap create <snap-name>                     create a snapshot
-    snap rollback <snap-name>                   rollback image to snapshot
-    snap rm <snap-name>                         deletes a snapshot
+    snap create --snap <snap-name> <image-name> create a snapshot
+    snap rollback --snap <snap-name> <image-name>
+                                                rollback image to snapshot
+    snap rm --snap <snap-name> <image-name>     deletes a snapshot
     snap purge <image-name>                     deletes all snapshots
     watch <image-name>                          watch events on image
     map <image-name>                            map image to a block device