]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
common/Formatter: trivial cons/des should be default 57374/head
authorPatrick Donnelly <pdonnell@redhat.com>
Wed, 1 May 2024 13:42:14 +0000 (09:42 -0400)
committerPatrick Donnelly <pdonnell@redhat.com>
Thu, 9 May 2024 13:50:06 +0000 (09:50 -0400)
See: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rc-five

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
src/common/Formatter.cc
src/common/Formatter.h

index b43e04a8bd09f2fad9b0a1a478f4bed1dda5edec..fa5051a5a214ecf02549febdbece5a714bcca42b 100644 (file)
@@ -78,10 +78,6 @@ FormatterAttrs::FormatterAttrs(const char *attr, ...)
 
 void Formatter::write_bin_data(const char*, int){}
 
-Formatter::Formatter() { }
-
-Formatter::~Formatter() { }
-
 Formatter *Formatter::create(std::string_view type,
                             std::string_view default_type,
                             std::string_view fallback)
index 65ffb0a68551edeed5a783e0fdf524d172e7e805..8fb7e378dcbb4ef28aa184ea53cb78418f1dfbff 100644 (file)
@@ -72,8 +72,8 @@ namespace ceph {
          Formatter::create(std::forward<Params>(params)...));
     }
 
-    Formatter();
-    virtual ~Formatter();
+    Formatter() = default;
+    virtual ~Formatter() = default;
 
     virtual void enable_line_break() = 0;
     virtual void flush(std::ostream& os) = 0;