librados: always free buffer allocated by md_config_t::_get_val

CID 717083: Resource leak (RESOURCE_LEAK)
At (3): Variable "str" going out of scope leaks the storage it points
to.

Signed-off-by: Josh Durgin <josh.durgin@inktank.com>

diff --git a/src/librados/librados.cc b/src/librados/librados.cc
index 82721a96aa5dda347fa999f9eadb3a586abf031f..274119c1b2807613989b41717b75d55e7d707bba 100644 (file)
--- a/src/librados/librados.cc
+++ b/src/librados/librados.cc
@@ -1113,11 +1113,13 @@ int librados::Rados::conf_set(const char *option, const char *value)
 
 int librados::Rados::conf_get(const char *option, std::string &val)
 {
-  char *str;
+  char *str = NULL;
   md_config_t *conf = client->cct->_conf;
   int ret = conf->get_val(option, &str, -1);
-  if (ret)
+  if (ret) {
+    free(str);
     return ret;
+  }
   val = str;
   free(str);
   return 0;