]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
ceph-crash: fix stderr handling
authorTim Serong <tserong@suse.com>
Wed, 2 Nov 2022 03:23:20 +0000 (14:23 +1100)
committerTim Serong <tserong@suse.com>
Thu, 3 Nov 2022 04:05:47 +0000 (15:05 +1100)
Popen.communicate() returns a tuple (stdout, stderr), and stderr
will be of type bytes, hence the need to decode it before checking
if it's an empty string or not.

Fixes: a77b47eeeb5770eeefcf4619ab2105ee7a6a003e
Signed-off-by: Tim Serong <tserong@suse.com>
src/ceph-crash.in

index 0fffd59a96df5ca193a9139a73e40c28aee7ad38..e2a7be59da7018c5170c7432debf81995c573832 100755 (executable)
@@ -50,7 +50,8 @@ def post_crash(path):
             stderr=subprocess.PIPE,
         )
         f = open(os.path.join(path, 'meta'), 'rb')
-        stderr = pr.communicate(input=f.read())
+        (_, stderr) = pr.communicate(input=f.read())
+        stderr = stderr.decode()
         rc = pr.wait()
         f.close()
         if rc != 0 or stderr != "":