mgr/prometheus: fix module crash when trying to collect OSDs metrics

Fixes: https://tracker.ceph.com/issues/57876
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit f8e4bcfd5929473e4aabbe20ade7c250234dbd52)

diff --git a/src/pybind/mgr/prometheus/module.py b/src/pybind/mgr/prometheus/module.py
index d100195b7d995fec3b6bbbe3ff1ac359429bd8e5..ae464a597010cd18a99b84b95fe62eba7471ebff 100644 (file)
--- a/src/pybind/mgr/prometheus/module.py
+++ b/src/pybind/mgr/prometheus/module.py
@@ -1094,8 +1094,9 @@ class Module(MgrModule):
         for server in self.list_servers():
             host = cast(str, server.get('hostname', ''))
             for service in cast(List[ServiceInfoT], server.get('services', [])):
-                ret.update({(service['id'], service['type']): (
-                    host, service['ceph_version'], service.get('name', ''))})
+                ret.update({(service['id'], service['type']): (host,
+                                                               service.get('ceph_version', 'unknown'),
+                                                               service.get('name', ''))})
         return ret
 
     @profile_method()