]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/osd: improve debugs in ECBackend::handle_rep_write_reply
authorRadosław Zarzyński <rzarzyns@redhat.com>
Tue, 24 Oct 2023 10:48:25 +0000 (12:48 +0200)
committerRadoslaw Zarzynski <rzarzyns@redhat.com>
Tue, 24 Mar 2026 16:06:23 +0000 (16:06 +0000)
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
src/crimson/osd/ec_backend.cc

index 5dbc96698a76b1efa41f1fe5cbeb66e36f86bc1f..ddc4891ba2bc27e11228ac31aaa846e49bd509a7 100644 (file)
@@ -402,11 +402,15 @@ ECBackend::handle_rep_write_op(
 ECBackend::write_iertr::future<>
 ECBackend::handle_rep_write_reply(ECSubWriteReply&& op)
 {
+  LOG_PREFIX(ECBackend::handle_rep_write_reply);
+  DEBUG("handling reply from osd.{}, tid {}",  op.from.osd, op.tid);
   assert(rmw_pipeline.tid_to_op_map.contains(op.tid));
   const auto& from = op.from;
   auto& wop = *rmw_pipeline.tid_to_op_map.at(op.tid);
   if (op.committed) {
     // TODO: trace.event("sub write committed");
+    logger().debug("ECBackend::{} from {} pending_commit {}",
+                   __func__, from, wop.pending_commit);
     ceph_assert(wop.pending_commit.count(from));
     wop.pending_commit.erase(from);
   }
@@ -420,7 +424,7 @@ ECBackend::handle_rep_write_reply(ECSubWriteReply&& op)
       wop.on_all_commit &&
       // also wait for apply, to preserve ordering with luminous peers.
       wop.pending_apply.empty()) {
-    logger().info("{}: calling on_all_commit on {}", __func__, wop);
+    logger().info("ECBackend::{}: calling on_all_commit on {}", __func__, wop);
     wop.on_all_commit->complete(0);
     wop.on_all_commit = 0;
     // TODO: wop.trace.event("ec write all committed");