]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
backport-resolve-issue: prune duplicate URLs 31247/head
authorNathan Cutler <ncutler@suse.com>
Wed, 30 Oct 2019 13:30:08 +0000 (14:30 +0100)
committerNathan Cutler <ncutler@suse.com>
Wed, 30 Oct 2019 13:30:08 +0000 (14:30 +0100)
I have seen PR descriptions with a single backport tracker URL mentioned twice.
When backport-resolve-issue hit one of these, it would say:

Found backport tracker: https://tracker.ceph.com/issues/39272
Found backport tracker: https://tracker.ceph.com/issues/39272
-----------------------------------------------------------------
INFO:root:Tracker https://tracker.ceph.com/issues/39272 links to PR https://github.com/ceph/ceph/pull/29153
INFO:root:Backport Tracker 39272 target version already populated with correct value v12.2.13
INFO:root:Backport Tracker 39272 status is already set to Resolved
-----------------------------------------------------------------
INFO:root:Tracker https://tracker.ceph.com/issues/39272 links to PR https://github.com/ceph/ceph/pull/29153
INFO:root:Backport Tracker 39272 target version already populated with correct value v12.2.13
INFO:root:Backport Tracker 39272 status is already set to Resolved
=================================================================

This commit fixes the issue.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
src/script/backport-resolve-issue

index c5df15f1f48fc65c3c8345b0ce8c6245a545e60b..2b4626595c1361ba78050e9c5d7222cb4de64e43 100755 (executable)
@@ -494,7 +494,7 @@ Ceph version:     base {}, target {}'''.format(self.github_url, pr_title_trunc,
             assert False, \
                 "GitHub PR description does not contain a Tracker URL"
         self.backport_trackers = []
-        for issue_url in matching_strings:
+        for issue_url in list(dict.fromkeys(matching_strings)):
             p = re.compile('\\d+')
             issue_id = p.search(issue_url).group()
             if not issue_id: