client/SyntheticClient.cc: fix another memory leak

Fix memory leak in read_random: call delete[] on buf before
call new[] again in the for-loop.

CID 717071 Resource leak (CWE-404)

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

diff --git a/src/client/SyntheticClient.cc b/src/client/SyntheticClient.cc
index 13337e9d14b540c3124afc58203a212b2017a544..7a2ab63a199831372c213ec4a5c3ead2d8591a27 100644 (file)
--- a/src/client/SyntheticClient.cc
+++ b/src/client/SyntheticClient.cc
@@ -2415,7 +2415,7 @@ int SyntheticClient::read_random(string& fn, int size, int rdsize)   // size is
 
     // cleanup before call 'new'
     if (buf != NULL) {
-       delete [] buf;
+       delete[] buf;
        buf = NULL;
     }
     if ( x < 0.5) 
@@ -2586,6 +2586,11 @@ int SyntheticClient::read_random_ex(string& fn, int size, int rdsize)   // size
     
     //dout(0) << "RANDOM NUMBER RETURN |" << x << "|" << dendl;
     
+    // cleanup before call 'new'
+    if (buf != NULL) {
+       delete[] buf;
+       buf = NULL;
+    }
     if ( x < 0.5) 
       {
         //dout(0) << "DECIDED TO READ " << x << dendl;