]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/osd: mark methods pure virtual
authorKefu Chai <kchai@redhat.com>
Wed, 4 Nov 2020 09:56:33 +0000 (17:56 +0800)
committerKefu Chai <kchai@redhat.com>
Wed, 4 Nov 2020 14:48:58 +0000 (22:48 +0800)
if the default implementation does not make sense in any case, just mark
it pure virtual.

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/crimson/os/futurized_store.h

index d7f3d585426b3e74e9cc45a3fe44c98f846f5141..744ef356e3561289c7ef8e4eaf18fb92bc6a1660 100644 (file)
@@ -28,21 +28,13 @@ class FuturizedStore {
 public:
   class OmapIterator {
   public:
-    virtual seastar::future<> seek_to_first() {
-      return seastar::make_ready_future<>();
-    }
-    virtual seastar::future<> upper_bound(const std::string &after) {
-      return seastar::make_ready_future<>();
-    }
-    virtual seastar::future<> lower_bound(const std::string &to) {
-      return seastar::make_ready_future<>();
-    }
+    virtual seastar::future<> seek_to_first() = 0;
+    virtual seastar::future<> upper_bound(const std::string &after) = 0;
+    virtual seastar::future<> lower_bound(const std::string &to) = 0;
     virtual bool valid() const {
       return false;
     }
-    virtual seastar::future<> next() {
-      return seastar::make_ready_future<>();
-    }
+    virtual seastar::future<> next() = 0;
     virtual std::string key() {
       return {};
     }