]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
os/bluestore: fix _extend_log seq advance
authorPere Diaz Bou <pdiabou@redhat.com>
Fri, 29 Sep 2023 11:17:03 +0000 (13:17 +0200)
committerYuri Weinstein <yweinste@redhat.com>
Wed, 30 Apr 2025 17:53:04 +0000 (17:53 +0000)
when extending the log, the sequence was left on a bad state because it would first create a transaction to update with the current seq number but leave the "real" transaction with the same sequence number which should be `extend_log_transaction.seq + 1`.

Signed-off-by: Pere Diaz Bou <pdiabou@redhat.com>
(cherry picked from commit 63f0a0df14c9d8e68be61e374438bc75cef45a1f)

Fixes: https://tracker.ceph.com/issues/69764
(cherry picked from commit 0210f57a5ec8a8c0ea76a72984f39dae24986cb0)

src/os/bluestore/BlueFS.cc

index 34251fe3b094514605217dbb939e30da5888b10a..837ca05845bad1fc70718958553317e6062ef552 100644 (file)
@@ -3133,12 +3133,13 @@ void BlueFS::_extend_log(uint64_t amount) {
   _pad_bl(bl, super.block_size);
   log.writer->append(bl);
   ceph_assert(allocated_before_extension >= log.writer->get_effective_write_pos());
-  log.t.seq = log.seq_live;
 
   // before sync_core we advance the seq
   {
     std::unique_lock<ceph::mutex> l(dirty.lock);
-    _log_advance_seq();
+    dirty.seq_live++;
+    log.seq_live++;
+    log.t.seq++;
   }
 }