]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
cephadm: move jaeger tracing daemon args out of _get_daemon_args
authorJohn Mulligan <jmulligan@redhat.com>
Fri, 20 Oct 2023 15:11:27 +0000 (11:11 -0400)
committerJohn Mulligan <jmulligan@redhat.com>
Sat, 4 Nov 2023 18:53:07 +0000 (14:53 -0400)
Signed-off-by: John Mulligan <jmulligan@redhat.com>
src/cephadm/cephadm.py

index 644f4fa60cf5fc349c1f4aaaa95114ef161b0a1d..3c95123046f9947e41fc330bceba9183bf279572 100755 (executable)
@@ -2328,9 +2328,6 @@ def _get_daemon_args(ctx: CephadmContext, ident: 'DaemonIdentity') -> List[str]:
     elif daemon_type in Monitoring.components:
         monitoring = Monitoring.create(ctx, ident)
         r += monitoring.get_daemon_args()
-    elif daemon_type == 'jaeger-agent':
-        tracing = Tracing.create(ctx, ident)
-        r += tracing.get_daemon_args()
 
     return r
 
@@ -2790,6 +2787,9 @@ def get_container(
         config = fetch_configs(ctx)
         Tracing.set_configuration(config, daemon_type)
         envs.extend(Tracing.components[daemon_type].get('envs', []))
+        if daemon_type == 'jaeger-agent':
+            tracing = Tracing.create(ctx, ident)
+            d_args.extend(tracing.get_daemon_args())
     elif daemon_type == NFSGanesha.daemon_type:
         entrypoint = NFSGanesha.entrypoint
         name = ident.daemon_name