]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/dashboard: bump node to 20.18.1 55875/head
authorNizamudeen A <nia@redhat.com>
Mon, 16 Jun 2025 04:50:45 +0000 (10:20 +0530)
committerNizamudeen A <nia@redhat.com>
Mon, 16 Jun 2025 11:09:57 +0000 (16:39 +0530)
one of the inner dependency expects it
```
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'undici@7.10.0',
npm WARN EBADENGINE   required: { node: '>=20.18.1' },
npm WARN EBADENGINE   current: { node: 'v20.13.1', npm: '10.5.2' }
npm WARN EBADENGINE }

```

Fixes: https://tracker.ceph.com/issues/70934
Signed-off-by: Nizamudeen A <nia@redhat.com>
doc/dev/developer_guide/dash-devel.rst
make-dist
src/pybind/mgr/dashboard/frontend/.nvmrc
src/pybind/mgr/dashboard/frontend/CMakeLists.txt

index 9b02e25dfc4a3b37e5847d0c2c59941d9128c173..8b2db7d7c188a3a1a3d9c6884b8d47897105bc17 100644 (file)
@@ -211,7 +211,7 @@ The build process is based on `Node.js <https://nodejs.org/>`_ and requires the
 Prerequisites
 ~~~~~~~~~~~~~
 
- * Node 20.13.1 or higher
+ * Node 20.18.1 or higher
  * NPM 10.5.2 or higher
 
 nodeenv:
index 86a9f85490e9982b9e1f3cd98f05b93db38694cb..c7967fea24b2a26c615cff11fce3077bc0518e4c 100755 (executable)
--- a/make-dist
+++ b/make-dist
@@ -133,7 +133,7 @@ build_dashboard_frontend() {
 
   $CURR_DIR/src/tools/setup-virtualenv.sh $TEMP_DIR
   $TEMP_DIR/bin/pip install nodeenv
-  $TEMP_DIR/bin/nodeenv --verbose -p --node=20.13.1
+  $TEMP_DIR/bin/nodeenv --verbose -p --node=20.18.1
   cd src/pybind/mgr/dashboard/frontend
 
   . $TEMP_DIR/bin/activate
index 9bcccb9439d9f4834373814391483986612bdb03..e8aa6441747056a809da60931dca711a800bd13f 100644 (file)
@@ -1 +1 @@
-v20.13.1
+v20.18.1
index ab4aa689385f26a1bb616bc19a3170e8292fb2f3..9e99ba95551216807c2b6df165b4b585598d192f 100644 (file)
@@ -64,7 +64,7 @@ else(WITH_SYSTEM_NPM)
     OUTPUT "${mgr-dashboard-nodeenv-dir}/bin/npm"
     COMMAND ${CMAKE_SOURCE_DIR}/src/tools/setup-virtualenv.sh --python=${MGR_PYTHON_EXECUTABLE} ${mgr-dashboard-nodeenv-dir}
     COMMAND ${mgr-dashboard-nodeenv-dir}/bin/pip install nodeenv
-    COMMAND ${mgr-dashboard-nodeenv-dir}/bin/nodeenv --verbose ${node_mirror_opt} -p --node=20.13.1
+    COMMAND ${mgr-dashboard-nodeenv-dir}/bin/nodeenv --verbose ${node_mirror_opt} -p --node=20.18.1
     # ensure that the files that nodeenv unpacks from tarballs are owned by
     # the current user. This can be an issue due to the node tarball using
     # uid 1000 and running the unpack in a id-mapped namespace (container)