]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/dashboard: migrate nvmeof pr #1238 to new cli
authorTomer Haskalovitch <il033030@Tomers-MBP.lan>
Mon, 23 Jun 2025 20:23:05 +0000 (23:23 +0300)
committerTomer Haskalovitch <tomer.haska@ibm.com>
Tue, 1 Jul 2025 09:43:12 +0000 (12:43 +0300)
Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
src/pybind/mgr/dashboard/controllers/nvmeof.py
src/pybind/mgr/dashboard/model/nvmeof.py

index 8c8987b769e222e7691bdf5e93000f3419ce2e83..caf91ba4961003768321880d2874e8362fc1bd44 100644 (file)
@@ -874,7 +874,9 @@ else:
         @NvmeofCLICommand("nvmeof connection list", model.ConnectionList)
         @convert_to_model(model.ConnectionList)
         @handle_nvmeof_error
-        def list(self, nqn: str, gw_group: Optional[str] = None, traddr: Optional[str] = None):
+        def list(self, nqn: Optional[str] = None, gw_group: Optional[str] = None, traddr: Optional[str] = None):
+            if not nqn:
+                nqn = '*'
             return NVMeoFClient(gw_group=gw_group, traddr=traddr).stub.list_connections(
                 NVMeoFClient.pb2.list_connections_req(subsystem=nqn)
             )
index 00ef36280dc4f808d9e8d36a8295f42d8218fcd4..dc4c8e2115d263d140bc17c7d01ea1202fcb0925 100644 (file)
@@ -94,6 +94,7 @@ class Connection(NamedTuple):
     connected: bool
     qpairs_count: int
     controller_id: int
+    subsystem: Optional[str]
 
 
 class ConnectionList(NamedTuple):