]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
qa: unmount volumes before removal
authorPatrick Donnelly <pdonnell@redhat.com>
Fri, 30 Oct 2020 21:40:25 +0000 (14:40 -0700)
committerPatrick Donnelly <pdonnell@redhat.com>
Tue, 3 Nov 2020 21:00:53 +0000 (13:00 -0800)
To avoid potential failures/hangs in umount.

Fixes: https://tracker.ceph.com/issues/23718
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
qa/tasks/cephfs/test_volumes.py

index 1dfd5877beaaf1904307146cb9fce58db60d5be0..c325b96b39f2e1c7cf7a12766a5dd1e5deeaf72a 100644 (file)
@@ -413,6 +413,8 @@ class TestVolumes(TestVolumesHelper):
         That the volume can only be removed when --yes-i-really-mean-it is used
         and verify that the deleted volume is not listed anymore.
         """
+        for m in self.mounts:
+            m.umount_wait()
         try:
             self._fs_cmd("volume", "rm", self.volname)
         except CommandFailedError as ce:
@@ -435,6 +437,8 @@ class TestVolumes(TestVolumesHelper):
         That the arbitrary pool added to the volume out of band is removed
         successfully on volume removal.
         """
+        for m in self.mounts:
+            m.umount_wait()
         new_pool = "new_pool"
         # add arbitrary data pool
         self.fs.add_data_pool(new_pool)
@@ -456,6 +460,8 @@ class TestVolumes(TestVolumesHelper):
         That the volume can only be removed when mon_allowd_pool_delete is set
         to true and verify that the pools are removed after volume deletion.
         """
+        for m in self.mounts:
+            m.umount_wait()
         self.config_set('mon', 'mon_allow_pool_delete', False)
         try:
             self._fs_cmd("volume", "rm", self.volname, "--yes-i-really-mean-it")