Merge pull request #31589 from zhengchengyao/mv_snapshot

librbd:move all snapshot API functions in internal.cc over to api/Snapshot.cc

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

diff --cc src/librbd/internal.cc
Simple merge

diff --cc src/librbd/librbd.cc
index fdd7c17d99e558200403a3edd2d82c9b45397285,cd4738b8b6762df54a75e81bfc8b0289a151a19e..0b8db4ff8b7957d17c2e061f596c6dd3cc3dcab7
--- 1/src/librbd/librbd.cc
--- 2/src/librbd/librbd.cc
+++ b/src/librbd/librbd.cc
@@@ -5152,10 -5148,9 +5152,10 @@@ extern "C" int rbd_snap_list(rbd_image_
      tracepoint(librbd, snap_list_exit, -EINVAL, 0);
      return -EINVAL;
    }
 +  // FIPS zeroization audit 20191117: this memset is not security related.
    memset(snaps, 0, sizeof(*snaps) * *max_snaps);
  
-   int r = librbd::snap_list(ictx, cpp_snaps);
+   int r = librbd::api::Snapshot<>::list(ictx, cpp_snaps);
    if (r == -ENOENT) {
      tracepoint(librbd, snap_list_exit, 0, *max_snaps);
      return 0;