]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
cephadm: consider stdout to get container version 48208/head
authorTatjana Dehler <tdehler@suse.com>
Wed, 14 Sep 2022 14:36:16 +0000 (16:36 +0200)
committerTatjana Dehler <tdehler@suse.com>
Mon, 26 Sep 2022 09:35:11 +0000 (11:35 +0200)
Fixes: https://tracker.ceph.com/issues/57558
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit d6156ede8b2d26b76403be39b62106ec2c4fb3b7)

src/cephadm/cephadm

index 4e48b261e2d4bcff0829f062ff396aef730d7812..07f12e75c717210c6a64a21e27367d10d15d0a50 100755 (executable)
@@ -627,10 +627,11 @@ class Monitoring(object):
         cmd = daemon_type.replace('-', '_')
         code = -1
         err = ''
+        out = ''
         version = ''
         if daemon_type == 'alertmanager':
             for cmd in ['alertmanager', 'prometheus-alertmanager']:
-                _, err, code = call(ctx, [
+                out, err, code = call(ctx, [
                     ctx.container_engine.path, 'exec', container_id, cmd,
                     '--version'
                 ], verbosity=CallVerbosity.QUIET)
@@ -638,12 +639,14 @@ class Monitoring(object):
                     break
             cmd = 'alertmanager'  # reset cmd for version extraction
         else:
-            _, err, code = call(ctx, [
+            out, err, code = call(ctx, [
                 ctx.container_engine.path, 'exec', container_id, cmd, '--version'
             ], verbosity=CallVerbosity.QUIET)
-        if code == 0 and \
-                err.startswith('%s, version ' % cmd):
-            version = err.split(' ')[2]
+        if code == 0:
+            if err.startswith('%s, version ' % cmd):
+                version = err.split(' ')[2]
+            elif out.startswith('%s, version ' % cmd):
+                version = out.split(' ')[2]
         return version
 
 ##################################