qa/tasks/mgr/test_insights: crash module now rejects bad crash reports

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 3bddcc5ddf1a96413a9efa439b167a471eee362d)

diff --git a/qa/tasks/mgr/test_insights.py b/qa/tasks/mgr/test_insights.py
index 37fe0a89c88d4194bb038123cf5514c1be8d6186..8f0f41ceb66310aac878e7b079352c24432613f9 100644 (file)
--- a/qa/tasks/mgr/test_insights.py
+++ b/qa/tasks/mgr/test_insights.py
@@ -163,23 +163,6 @@ class TestInsights(MgrTestCase):
         report = self._insights()
         self.assertFalse(report["health"]["history"]["checks"])
 
-    def test_insights_health(self):
-        """The insights module reports health checks"""
-        self._add_crash(1, True) # add invalid crash data
-        timeout = 10
-        while timeout > 0:
-            time.sleep(1)
-            timeout -= 1
-            # should observe a health check because it can't read the invalid
-            # crash data created at the beginning of this test
-            report = self._insights()
-            if "MGR_INSIGHTS_WARNING" in report["health"]["current"]["checks"]:
-                self._clear_crashes()
-                return
-        self._clear_crashes()
-        self.fail("Insights module did not set health check")
-        pass
-
     def test_schema(self):
         """TODO: assert conformance to a full schema specification?"""
         report = self._insights()
@@ -214,10 +197,4 @@ class TestInsights(MgrTestCase):
         self.assertFalse(report["errors"])
         log.warning("{}".format(json.dumps(report["crashes"], indent=2)))
 
-        # handling of comm. error with crash module
-        self._add_crash(1, True)
-        report = self._insights()
-        self.assertFalse(report["crashes"]["summary"])
-        self.assertTrue(report["errors"])
-
         self._clear_crashes()