]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
Merge PR #31890 into master
authorSage Weil <sage@redhat.com>
Tue, 3 Dec 2019 16:38:28 +0000 (10:38 -0600)
committerSage Weil <sage@redhat.com>
Tue, 3 Dec 2019 16:38:28 +0000 (10:38 -0600)
* refs/pull/31890/head:
mgr/orchestrator: name rgw by client.rgw.$realm.$zone[.$id]

Reviewed-by: Ali Maredia <amaredia@redhat.com>
1  2 
.githubmap
src/pybind/mgr/orchestrator.py
src/pybind/mgr/orchestrator_cli/module.py
src/pybind/mgr/ssh/module.py

diff --cc .githubmap
index c2b6c776551b0a1920c8c2367ec552d65bc635df,21e4cd3144cf61bb143c25815620a68aef5578a5..0944c6e319f3b954a37affceb9accc1a7cd986c8
@@@ -108,5 -108,3 +108,6 @@@ mgfritch Michael Fritch <mfritch@suse.c
  xiaoxichen Xiaoxi Chen <superdebuger@gmail.com>
  toabctl Thomas Bechtold <tbechtold@suse.com>
  dsavineau Dimitri Savineau <dsavinea@redhat.com>
 +jschmid1 Joshua Schmid <jschmid@suse.de>
 +bk201 Kiefer Chang <kiefer.chang@suse.com>
++alimaredia Ali Maredia <amaredia@redhat.com>
Simple merge
index 7676eb1a62671df5dce362042d22796529072ad2,a86649d4f9e4861fd798ad23f0e24ddbfe87c2f9..0c2048fabd527a3902eedf3549526332360852c2
@@@ -1268,30 -1169,34 +1268,36 @@@ class SSHOrchestrator(MgrModule, orches
              'prefix': 'config set',
              'who': 'client.rgw.' + spec.name,
              'name': 'rgw_zone',
-             'value': spec.name,
+             'value': spec.rgw_zone,
+         })
+         ret, out, err = self.mon_command({
+             'prefix': 'config set',
+             'who': 'client.rgw.' + spec.rgw_realm,
+             'name': 'rgw_realm',
+             'value': spec.rgw_realm,
          })
 -        daemons = self._get_services('rgw')
 -        results = []
 -        num_added = 0
 -        for host, _, name in spec.placement.nodes:
 -            if num_added >= spec.count:
 -                break
 -            rgw_id = self.get_unique_name(daemons, spec.name, name)
 -            self.log.debug('placing rgw.%s on host %s' % (rgw_id, host))
 -            results.append(
 -                self._worker_pool.apply_async(self._create_rgw, (rgw_id, host))
 -            )
 -            # add to daemon list so next name(s) will also be unique
 -            sd = orchestrator.ServiceDescription()
 -            sd.service_instance = rgw_id
 -            sd.service_type = 'rgw'
 -            sd.nodename = host
 -            daemons.append(sd)
 -            num_added += 1
 -        return SSHWriteCompletion(results)
  
 +        def _add_rgw(daemons):
 +            args = []
 +            num_added = 0
 +            for host, _, name in spec.placement.nodes:
 +                if num_added >= spec.count:
 +                    break
 +                rgw_id = self.get_unique_name(daemons, spec.name, name)
 +                self.log.debug('placing rgw.%s on host %s' % (rgw_id, host))
 +                args.append((rgw_id, host))
 +                # add to daemon list so next name(s) will also be unique
 +                sd = orchestrator.ServiceDescription()
 +                sd.service_instance = rgw_id
 +                sd.service_type = 'rgw'
 +                sd.nodename = host
 +                daemons.append(sd)
 +                num_added += 1
 +            return self._create_rgw(args)
 +
 +        return self._get_services('rgw').then(_add_rgw)
 +
 +    @async_map_completion
      def _create_rgw(self, rgw_id, host):
          ret, keyring, err = self.mon_command({
              'prefix': 'auth get-or-create',