]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
osd/ReplicatedPG.cc: remove redundant check
authorDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Thu, 30 Oct 2014 04:16:34 +0000 (05:16 +0100)
committerDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Tue, 11 Nov 2014 12:26:37 +0000 (13:26 +0100)
Fix for:

[src/osd/ReplicatedPG.cc:2171]: (style) Redundant checking of STL
 container element existence before removing it.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
src/osd/ReplicatedPG.cc

index d6ecd9473cfd8b693572ae276538bf1ee3561860..55adf12a9f59f92bc4e061df1309480600602421 100644 (file)
@@ -2326,9 +2326,7 @@ void ReplicatedPG::do_scan(
       }
       peer_backfill_info[from] = bi;
 
-      if (waiting_on_backfill.find(from) != waiting_on_backfill.end()) {
-       waiting_on_backfill.erase(from);
-
+      if (waiting_on_backfill.erase(from)) {
        if (waiting_on_backfill.empty()) {
          assert(peer_backfill_info.size() == backfill_targets.size());
          finish_recovery_op(hobject_t::get_max());