]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mon/PGMap: fix condition checking for slow-requests
authorxie xingguo <xie.xingguo@zte.com.cn>
Mon, 24 Jul 2017 08:28:13 +0000 (16:28 +0800)
committerxie xingguo <xie.xingguo@zte.com.cn>
Tue, 25 Jul 2017 02:24:44 +0000 (10:24 +0800)
op_queue_age_hist collects op stats in ms, not sec.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
src/mon/PGMap.cc

index b907003c6d5fe91b57214045c00ca23c172d9b2b..076c618ce84f20a39cfcfe17075cb1b4dc09507c 100644 (file)
@@ -3054,7 +3054,8 @@ void PGMap::get_health_checks(
   // REQUEST_SLOW
   // REQUEST_STUCK
   if (cct->_conf->mon_osd_warn_op_age > 0 &&
-      osd_sum.op_queue_age_hist.upper_bound() >
+      !osd_sum.op_queue_age_hist.h.empty() &&
+      osd_sum.op_queue_age_hist.upper_bound() / 1000.0 >
       cct->_conf->mon_osd_warn_op_age) {
     list<string> warn_detail, error_detail;
     unsigned warn = 0, error = 0;
@@ -3364,7 +3365,8 @@ void PGMap::get_health(
 
   // slow requests
   if (cct->_conf->mon_osd_warn_op_age > 0 &&
-      osd_sum.op_queue_age_hist.upper_bound() > cct->_conf->mon_osd_warn_op_age) {
+      osd_sum.op_queue_age_hist.upper_bound() / 1000.0  >
+      cct->_conf->mon_osd_warn_op_age) {
     auto sum = _warn_slow_request_histogram(
       cct, osd_sum.op_queue_age_hist, "", summary, NULL);
     if (sum.first > 0 || sum.second > 0) {