]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
ceph-backport.sh: --existing-pr ... --force should update PR body
authorNathan Cutler <ncutler@suse.com>
Tue, 5 Nov 2019 15:51:31 +0000 (16:51 +0100)
committerNathan Cutler <ncutler@suse.com>
Fri, 8 Nov 2019 07:19:48 +0000 (08:19 +0100)
Signed-off-by: Nathan Cutler <ncutler@suse.com>
src/script/ceph-backport.sh

index d2f968a336547f8474b7e49281bedbf5ef6a6ec8..b4d747f21466418cb2f4a2f43b34865c6e7b20b7 100755 (executable)
@@ -373,9 +373,16 @@ function existing_pr_routine {
     redmine_url_without_scheme="${redmine_url//http?:\/\//}"
     verbose "Redmine URL without scheme: $redmine_url_without_scheme"
     if [[ "$clipped_pr_body" =~ $redmine_url_without_scheme ]] ; then
-        verbose "Existing backport PR ${backport_pr_number} mentions $redmine_url"
+        info "Existing backport PR ${backport_pr_number} already mentions $redmine_url"
+        if [ "$FORCE" ] ; then
+            warning "--force was given, so updating the PR body anyway"
+            update_pr_body="yes"
+        fi
     else
         warning "Existing backport PR ${backport_pr_number} does NOT mention $redmine_url - adding it"
+        update_pr_body="yes"
+    fi
+    if [ "$update_pr_body" ] ; then
         new_pr_body="backport tracker: ${redmine_url}"
         if [ "${original_pr_url}" ] ; then
             new_pr_body="${new_pr_body}