tools/rados: support more --format options

Signed-off-by: Kefu Chai <kchai@redhat.com>

diff --git a/src/tools/rados/rados.cc b/src/tools/rados/rados.cc
index fb4967f7579977c1f2641b6048d832b145bee737..1538ee27527d2b1c40515b98eb80e123a4b49d66 100644 (file)
--- a/src/tools/rados/rados.cc
+++ b/src/tools/rados/rados.cc
@@ -1407,11 +1407,8 @@ static int rados_tool_common(const std::map < std::string, std::string > &opts,
   i = opts.find("format");
   if (i != opts.end()) {
     const char *format = i->second.c_str();
-    if (strcmp(format, "xml") == 0)
-      formatter = new XMLFormatter(pretty_format);
-    else if (strcmp(format, "json") == 0)
-      formatter = new JSONFormatter(pretty_format);
-    else {
+    formatter = Formatter::create(format);
+    if (!formatter) {
       cerr << "unrecognized format: " << format << std::endl;
       return -EINVAL;
     }