mgr/orch: apply: Fix proper error when passed unknown type

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>

diff --git a/src/pybind/mgr/orchestrator/module.py b/src/pybind/mgr/orchestrator/module.py
index 0518941c6e0f964ed8d1e9236cc075619aafee3a..ec15f2ad786439da785ee19f2b1094343473c913 100644 (file)
--- a/src/pybind/mgr/orchestrator/module.py
+++ b/src/pybind/mgr/orchestrator/module.py
@@ -1000,7 +1000,9 @@ Usage:
 
         else:
             placmentspec = PlacementSpec.from_string(placement)
-            assert service_type
+            if not service_type:
+                raise OrchestratorValidationError(f'Error: Empty service_type\n{usage}')
+
             specs = [ServiceSpec(service_type, placement=placmentspec, unmanaged=unmanaged)]
  
         completion = self.apply(specs)