]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
common/blkdev: take queue/ prefix as part of property name
authorSage Weil <sage@redhat.com>
Fri, 24 Mar 2017 00:31:37 +0000 (19:31 -0500)
committerSage Weil <sage@redhat.com>
Wed, 29 Mar 2017 17:23:59 +0000 (13:23 -0400)
This way we can get at properties in device/ too.

Signed-off-by: Sage Weil <sage@redhat.com>
src/common/blkdev.cc
src/test/common/test_blkdev.cc

index 17fe0e6ac835725211bf40b683947ddf472e07d2..23818fcf52bf29936493d39c6acd8aa41b1dda43 100644 (file)
@@ -141,7 +141,7 @@ int64_t get_block_device_int_property(const char *devname, const char *property)
     return r;
 
   snprintf(filename, sizeof(filename),
-          "%s/sys/block/%s/queue/%s", sandbox_dir, basename, property);
+          "%s/sys/block/%s/%s", sandbox_dir, basename, property);
 
   FILE *fp = fopen(filename, "r");
   if (fp == NULL) {
@@ -170,7 +170,7 @@ int64_t get_block_device_int_property(const char *devname, const char *property)
 
 bool block_device_support_discard(const char *devname)
 {
-  return get_block_device_int_property(devname, "discard_granularity") > 0;
+  return get_block_device_int_property(devname, "queue/discard_granularity") > 0;
 }
 
 int block_device_discard(int fd, int64_t offset, int64_t len)
@@ -181,7 +181,7 @@ int block_device_discard(int fd, int64_t offset, int64_t len)
 
 bool block_device_is_rotational(const char *devname)
 {
-  return get_block_device_int_property(devname, "rotational") > 0;
+  return get_block_device_int_property(devname, "queue/rotational") > 0;
 }
 
 int get_device_by_uuid(uuid_d dev_uuid, const char* label, char* partition,
index 33889685eb0dbea3b3e5ac0492cb7121d038acb7..d750ac5999f4c990d00078badc1ed1086d9a9443 100644 (file)
@@ -47,7 +47,7 @@ TEST(blkdev, get_block_device_base) {
       printf("  got '%s' expected '%s'\n", buf3, de->d_name);
       ASSERT_EQ(0, strcmp(de->d_name, buf3));
       printf("  discard granularity = %lld .. supported = %d\n",
-            (long long)get_block_device_int_property(base, "discard_granularity"),
+            (long long)get_block_device_int_property(base, "queue/discard_granularity"),
             (int)block_device_support_discard(base));
 
       char subdirfn[PATH_MAX];
@@ -74,7 +74,7 @@ TEST(blkdev, get_block_device_base) {
        printf("  got '%s' expected '%s'\n", buf3, de->d_name);
        ASSERT_EQ(0, strcmp(buf3, de->d_name));
        printf("  discard granularity = %lld .. supported = %d\n",
-              (long long)get_block_device_int_property(part, "discard_granularity"),
+              (long long)get_block_device_int_property(part, "queue/discard_granularity"),
               (int)block_device_support_discard(part));
       }