]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
librbd: fix wrong attribute for rbd_quiesce_complete api 50735/head
authorDongsheng Yang <dongsheng.yang.linux@gmail.com>
Wed, 15 Mar 2023 06:54:39 +0000 (06:54 +0000)
committerDongsheng Yang <dongsheng.yang@easystack.cn>
Wed, 29 Mar 2023 11:49:55 +0000 (11:49 +0000)
When we use rbd_quiesce_complete api, we got an error:
/usr/bin/ld: undefined reference to `rbd_quiesce_complete'

Then we found the problem is the symbol of rbd_quiesce_complete
in librbd.so is LOCAL. After some investigation, we found
the attribute of rbd_quiesce_complete api is CEPH_RADOS_API
rather than expected CEPH_RBD_API.

Fixes: https://tracker.ceph.com/issues/59208
Signed-off-by: Dongsheng Yang <dongsheng.yang.linux@gmail.com>
src/include/rbd/librbd.h

index b99421d1f2a527518f269c44d3cb75bfcf93a7b3..7ae20e4dd583beb6ad76c376dd5c0a7dbedc049d 100644 (file)
@@ -1526,8 +1526,8 @@ CEPH_RBD_API int rbd_quiesce_watch(rbd_image_t image,
  * @param handle which watch is complete
  * @param r the return code
  */
-CEPH_RADOS_API void rbd_quiesce_complete(rbd_image_t image, uint64_t handle,
-                                         int r);
+CEPH_RBD_API void rbd_quiesce_complete(rbd_image_t image, uint64_t handle,
+                                       int r);
 
 /**
  * Unregister a quiesce/unquiesce watcher.