]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
common: drop at_buffer_{head,tail} from buffer::ptr. 25422/head
authorRadoslaw Zarzynski <rzarzyns@redhat.com>
Thu, 6 Dec 2018 10:05:38 +0000 (11:05 +0100)
committerRadoslaw Zarzynski <rzarzyns@redhat.com>
Thu, 6 Dec 2018 11:20:15 +0000 (12:20 +0100)
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
src/common/buffer.cc
src/include/buffer.h
src/test/bufferlist.cc

index b1c533ed3100fb2b08891bd1e4e7bf98c523c887..5be023f0a272bb70c51af19336eeea941deff2b1 100644 (file)
@@ -654,8 +654,6 @@ using namespace ceph;
     }
   }
 
-  bool buffer::ptr::at_buffer_tail() const { return _off + _len == _raw->len; }
-
   int buffer::ptr::get_mempool() const {
     if (_raw) {
       return _raw->mempool;
index 56c5e8154e2866e42d63a2582aa836b2172fe8ae..ae491a5aea0593043a5f5b2008fcf8d38f000467 100644 (file)
@@ -296,9 +296,6 @@ namespace buffer CEPH_BUFFER_API {
     }
 
     // misc
-    bool at_buffer_head() const { return _off == 0; }
-    bool at_buffer_tail() const;
-
     bool is_aligned(unsigned align) const {
       return ((long)c_str() & (align-1)) == 0;
     }
index beb094fd83139081a3e268bcb7c9cd2de77450eb..a018bd561cb7fcbbf07ea1386ac1781a49356319 100644 (file)
@@ -464,20 +464,6 @@ TEST(BufferPtr, have_raw) {
   }
 }
 
-TEST(BufferPtr, at_buffer_head) {
-  bufferptr ptr(2);
-  EXPECT_TRUE(ptr.at_buffer_head());
-  ptr.set_offset(1);
-  EXPECT_FALSE(ptr.at_buffer_head());
-}
-
-TEST(BufferPtr, at_buffer_tail) {
-  bufferptr ptr(2);
-  EXPECT_TRUE(ptr.at_buffer_tail());
-  ptr.set_length(1);
-  EXPECT_FALSE(ptr.at_buffer_tail());
-}
-
 TEST(BufferPtr, is_n_page_sized) {
   {
     bufferptr ptr(CEPH_PAGE_SIZE);