]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson: osd: do not capture std::error_code by reference 43003/head
authorGreg Farnum <gfarnum@redhat.com>
Tue, 31 Aug 2021 20:18:49 +0000 (20:18 +0000)
committerGreg Farnum <gfarnum@redhat.com>
Wed, 1 Sep 2021 00:10:17 +0000 (00:10 +0000)
I can't find any reason to assume it has a longer lifetime than
the future we're creating has.

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
src/crimson/osd/pg.cc

index fbebbc4b8158b531e4b05b2f6bb269499698d86d..704b6bf563a55237f0595fa46db364b024940cd4 100644 (file)
@@ -716,7 +716,7 @@ PG::do_osd_ops_execute(
             [rollbacker, failure_func_ptr]
             (const std::error_code& e) mutable {
             return rollbacker.rollback_obc_if_modified(e).then_interruptible(
-              [&e, failure_func_ptr] {
+              [e, failure_func_ptr] {
               return (*failure_func_ptr)(e);
             });
           })
@@ -728,7 +728,7 @@ PG::do_osd_ops_execute(
     return PG::do_osd_ops_iertr::make_ready_future<pg_rep_op_fut_t<Ret>>(
         seastar::now(),
         rollbacker.rollback_obc_if_modified(e).then_interruptible(
-          [&e, failure_func_ptr] {
+          [e, failure_func_ptr] {
           return (*failure_func_ptr)(e);
         }));
   }));