crimson/common/smp_helpers: fix reactor_map_seq

Copy f into reactor_map_seq which would be kept alive
due to this method being a coroutine. That way, we can ensure
the lambdas passed to each core that are capturing f by
reference would be safe.
Alternatively, we can also copy f by using it's copy ctor and
pass a copy to each shard:
co_await crimson::submit_to(core, F(f))
However, avoiding the copy is possible here due to the sequential
traversal. Note, seastar's invoke_on_all do copy each callback to
every shard and is running the invocation in parallel.

The above would have fixed f's captures to be invalid and result
in a segfaults on diffrent shards.

Fixes: https://tracker.ceph.com/issues/71457
Signed-off-by: Matan Breizman <mbreizma@redhat.com>

diff --git a/src/crimson/common/smp_helpers.h b/src/crimson/common/smp_helpers.h
index e82aaecf1c6f62350efb1d55f856275e308c82ce..78ab118c185156759aa75efffea28826b197dd48 100644 (file)
--- a/src/crimson/common/smp_helpers.h
+++ b/src/crimson/common/smp_helpers.h
@@ -51,33 +51,17 @@ auto proxy_method_on_core(
  *
  * Invokes f on each reactor sequentially, Caller may assume that
  * f will not be invoked concurrently on multiple cores.
+ * f is copied here and is kept alive due to coroutine parameter copying.
  */
 template <typename F>
-auto reactor_map_seq(F &&f) {
-  using ret_type = decltype(f());
-  if constexpr (is_errorated_future_v<ret_type>) {
-    auto ret = crimson::do_for_each(
-      seastar::smp::all_cpus().begin(),
-      seastar::smp::all_cpus().end(),
-      [f=std::move(f)](auto core) mutable {
-       return seastar::smp::submit_to(
-         core,
-         [&f] {
-           return std::invoke(f);
-         });
-      });
-    return ret_type(ret);
-  } else {
-    return seastar::do_for_each(
-      seastar::smp::all_cpus().begin(),
-      seastar::smp::all_cpus().end(),
-      [f=std::move(f)](auto core) mutable {
-       return seastar::smp::submit_to(
-         core,
-         [&f] {
-           return std::invoke(f);
-         });
-      });
+auto reactor_map_seq(F f) -> decltype(seastar::futurize_invoke(f)) {
+  for (auto core: seastar::smp::all_cpus()) {
+    using ret_type = decltype(f());
+    if constexpr (is_errorated_future_v<ret_type>) {
+      co_await crimson::submit_to(core, [&f] { return seastar::futurize_invoke(f);});
+    } else {
+      co_await seastar::smp::submit_to(core, [&f] { return seastar::futurize_invoke(f);});
+    }
   }
 }