]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
ceph.spec.in: build with header only fmt on RHEL 42472/head
authorKefu Chai <kchai@redhat.com>
Fri, 23 Jul 2021 10:02:36 +0000 (18:02 +0800)
committerKefu Chai <kchai@redhat.com>
Sat, 24 Jul 2021 05:50:33 +0000 (13:50 +0800)
because fmt is packaged in EPEL, while librados is packaged
in RHEL, so we cannot have fmt as a runtime dependency of librados.
to address this issue, we should compile librados either with static library
or with header-only library of fmt. but because the fedora packaging
guideline does no encourage us to package static libraries, and it would
be complicated to package both static and dynamic library for fmt.

the simpler solution would be to compile Ceph with the header-only
version of fmt.

in this change, we compile ceph with the header-only version of fmt
on RHEL to address the runtime dependency issue.

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 5419131499f4c4b5f6ba520342c39f9766e0cf4d)

Conflicts:
ceph.spec.in: trivial resolution

ceph.spec.in

index 5e2ffec7d3f13e1d2535c123665fda56e091f06d..abac1ec19d99f5104f6bb0ceeb7055f179af13cf 100644 (file)
@@ -1335,6 +1335,9 @@ ${CMAKE} .. \
     -DWITH_SYSTEM_PMDK:BOOL=ON \
 %endif
     -DBOOST_J=$CEPH_SMP_NCPUS \
+%if 0%{?rhel}
+    -DWITH_FMT_HEADER_ONLY:BOOL=ON \
+%endif
     -DWITH_GRAFANA=ON
 
 %if %{with cmake_verbose_logging}