ceph-disk: handle missing journal_uuid field gracefully

Only lower if we know it's not None.

Signed-off-by: Sage Weil <sage@inktank.com>

diff --git a/src/ceph-disk b/src/ceph-disk
index fc6966406045ee971d41d7afc36e9ae400b820c4..c90fce0e3b10b446f1bc87b944ca5800366cadb7 100755 (executable)
--- a/src/ceph-disk
+++ b/src/ceph-disk
@@ -1671,9 +1671,11 @@ def more_osd_info(path, uuid_map):
     if who:
         desc.append('osd.%s' % who)
 
-    journal_uuid = get_oneliner(path, 'journal_uuid').lower()
-    if journal_uuid and journal_uuid in uuid_map:
-        desc.append('journal %s' % uuid_map[journal_uuid])
+    journal_uuid = get_oneliner(path, 'journal_uuid')
+    if journal_uuid:
+        journal_uuid = journal_uuid.lower()
+        if journal_uuid in uuid_map:
+            desc.append('journal %s' % uuid_map[journal_uuid])
 
     return desc
 
@@ -1747,9 +1749,9 @@ def main_list(args):
                 try:
                     tpath = mount(dev=dev, fstype=fs, options='')
                     try:
-                        journal_uuid = get_oneliner(tpath, 'journal_uuid').lower()
+                        journal_uuid = get_oneliner(tpath, 'journal_uuid')
                         if journal_uuid:
-                            journal_map[journal_uuid] = dev
+                            journal_map[journal_uuid.lower()] = dev
                     finally:
                         unmount(tpath)
                 except: