]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
test/system: fix a -Wsign-compare warning in compiling.
authorDongsheng Yang <dongsheng.yang@easystack.cn>
Wed, 30 Mar 2016 02:28:45 +0000 (22:28 -0400)
committerDongsheng Yang <dongsheng.yang@easystack.cn>
Thu, 31 Mar 2016 04:08:20 +0000 (00:08 -0400)
test/system/st_rados_create_pool.cc: In function ‘std::__cxx11::string get_temp_pool_name(const char*)’:
test/system/st_rados_create_pool.cc:128:9: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   assert(ret < sizeof(poolname));
         ^

Signed-off-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
src/test/system/st_rados_create_pool.cc

index b027860f51724245f388c237ff81b0bf8179b5c4..aeec7aef42e14c88d7e52963036004eb4268b694 100644 (file)
@@ -125,6 +125,7 @@ std::string get_temp_pool_name(const char* prefix)
   char poolname[256];
   ret = snprintf(poolname, sizeof(poolname),
                  "%s.%s-%d", prefix, hostname, getpid());
-  assert(ret < sizeof(poolname));
+  assert(ret > 0);
+  assert((unsigned int)ret < sizeof(poolname));
   return poolname;
 }