]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/orchestrator: pass 'force' flag down for remove_service
authorSage Weil <sage@newdream.net>
Mon, 8 Nov 2021 17:04:27 +0000 (12:04 -0500)
committerSage Weil <sage@newdream.net>
Tue, 9 Nov 2021 15:19:42 +0000 (10:19 -0500)
Signed-off-by: Sage Weil <sage@newdream.net>
src/pybind/mgr/cephadm/module.py
src/pybind/mgr/orchestrator/_interface.py
src/pybind/mgr/orchestrator/module.py
src/pybind/mgr/rook/module.py
src/pybind/mgr/test_orchestrator/module.py

index 27032cb873c847ac221dc3213dd412970b140bb0..145bcd4175c78751210786efd95e6c34b8031426 100644 (file)
@@ -1917,7 +1917,7 @@ Then run the following:
         return self._remove_daemons(args)
 
     @handle_orch_error
-    def remove_service(self, service_name: str) -> str:
+    def remove_service(self, service_name: str, force: bool = False) -> str:
         self.log.info('Remove service %s' % service_name)
         self._trigger_preview_refresh(service_name=service_name)
         if service_name in self.spec_store:
index 7fa3b5f34091a87a9fff9181594da957f0804ffc..9f86abe8db0a35ee4989322799cea24f363513bd 100644 (file)
@@ -490,7 +490,7 @@ class Orchestrator(object):
         """
         raise NotImplementedError()
 
-    def remove_service(self, service_name: str) -> OrchResult[str]:
+    def remove_service(self, service_name: str, force: bool = False) -> OrchResult[str]:
         """
         Remove a service (a collection of daemons).
 
index a3d809a68cb414e764489596d7779ea8e847182e..20bab4202a9f3a542388233c02fbd6b4913ac486 100644 (file)
@@ -1019,7 +1019,7 @@ Usage:
         """Remove a service"""
         if service_name in ['mon', 'mgr'] and not force:
             raise OrchestratorError('The mon and mgr services cannot be removed')
-        completion = self.remove_service(service_name)
+        completion = self.remove_service(service_name, force=force)
         raise_if_exception(completion)
         return HandleCommandResult(stdout=completion.result_str())
 
index c0c1c32c9f27ba04f47eb0e4aea6ca0b2e3137c2..93021d0c2efde2874abcf2caac763775720386ba 100644 (file)
@@ -463,7 +463,7 @@ class RookOrchestrator(MgrModule, orchestrator.Orchestrator):
         return num_replicas, leaf_type
 
     @handle_orch_error
-    def remove_service(self, service_name: str) -> str:
+    def remove_service(self, service_name: str, force: bool = False) -> str:
         if service_name == 'rbd-mirror':
             return self.rook_cluster.rm_service('cephrbdmirrors', 'default-rbd-mirror')
         service_type, service_name = service_name.split('.', 1)
index 9d172737777fe51b2a8f7954bc570ed8ca2d90b4..d89c23bf1593c679890c77bc7fac13338be72a29 100644 (file)
@@ -227,7 +227,7 @@ class TestOrchestrator(MgrModule, orchestrator.Orchestrator):
         return 'done'
 
     @handle_orch_error
-    def remove_service(self, service_name):
+    def remove_service(self, service_name, force = False):
         assert isinstance(service_name, str)
         return 'done'