]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mds: fix double-unlock on shutdown 10847/head
authorGreg Farnum <gfarnum@redhat.com>
Wed, 24 Aug 2016 20:34:43 +0000 (13:34 -0700)
committerGreg Farnum <gfarnum@redhat.com>
Wed, 24 Aug 2016 21:20:49 +0000 (14:20 -0700)
We did a bad backport or something and accidentally ended up with two Unlock()
calls on mds_lock. Don't.

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
src/mds/MDSRank.cc

index 8ddd2faa40c24c7cfc6b98bf429b2af3caf78186..5c2bfe39ebb4101637466261611e32cfaf6d522e 100644 (file)
@@ -242,13 +242,7 @@ void MDSRankDispatcher::shutdown()
   mds_lock.Unlock();
 
   finisher->stop(); // no flushing
-
-  // shut down messenger
-  // release mds_lock first because messenger thread might call 
-  // MDSDaemon::ms_handle_reset which will try to hold mds_lock
-  mds_lock.Unlock();
   messenger->shutdown();
-  mds_lock.Lock();
 
   mds_lock.Lock();