]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
ceph-volume util.prepare use keyfile from stdin for mkfs in filestore
authorAlfredo Deza <adeza@redhat.com>
Wed, 7 Mar 2018 16:56:45 +0000 (11:56 -0500)
committerAlfredo Deza <adeza@redhat.com>
Wed, 1 Aug 2018 14:39:23 +0000 (10:39 -0400)
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 70b495ac06b1fa382654759764014d5391d67f9a)

src/ceph-volume/ceph_volume/util/prepare.py

index 2c36ba0ec450cdadbec0f90cb27ac5299bcaa820..319964401f768f0d58a324b3d21c7f99278f4289 100644 (file)
@@ -339,7 +339,7 @@ def osd_mkfs_bluestore(osd_id, fsid, keyring=None, wal=False, db=False):
         raise RuntimeError('Command failed with exit code %s: %s' % (returncode, ' '.join(command)))
 
 
-def osd_mkfs_filestore(osd_id, fsid):
+def osd_mkfs_filestore(osd_id, fsid, keyring):
     """
     Create the files for the OSD to function. A normal call will look like:
 
@@ -359,7 +359,7 @@ def osd_mkfs_filestore(osd_id, fsid):
     system.chown(journal)
     system.chown(path)
 
-    process.run([
+    command = [
         'ceph-osd',
         '--cluster', conf.cluster,
         # undocumented flag, sets the `type` file to contain 'filestore'
@@ -367,9 +367,11 @@ def osd_mkfs_filestore(osd_id, fsid):
         '--mkfs',
         '-i', osd_id,
         '--monmap', monmap,
+        '--keyfile', '-', # goes through stdin
         '--osd-data', path,
         '--osd-journal', journal,
         '--osd-uuid', fsid,
         '--setuser', 'ceph',
         '--setgroup', 'ceph'
-    ])
+    ]
+    process.call(command, stdin=keyring, terminal_verbose=True, show_command=True)