]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
msgr: adjust mark_down locking to avoid possible race
authorSage Weil <sage@newdream.net>
Mon, 17 Nov 2008 17:01:30 +0000 (09:01 -0800)
committerSage Weil <sage@newdream.net>
Mon, 17 Nov 2008 17:06:54 +0000 (09:06 -0800)
src/msg/SimpleMessenger.cc

index e4401f73d497604b559c727947ec1357ab378b4b..60599782b0fbb52842a1f09d3edbab33e1249f6c 100644 (file)
@@ -776,14 +776,13 @@ void Rank::mark_down(entity_addr_t addr)
     Pipe *p = rank_pipe[addr];
     dout(2) << "mark_down " << addr << " -- " << p << dendl;
     p->unregister_pipe();
-    lock.Unlock();
     p->lock.Lock();
     p->stop();
     p->lock.Unlock();
   } else {
-    lock.Unlock();
     dout(2) << "mark_down " << addr << " -- pipe dne" << dendl;
   }
+  lock.Unlock();
 }