]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/osd: do not capture dup variable
authorKefu Chai <kchai@redhat.com>
Tue, 15 Dec 2020 08:47:20 +0000 (16:47 +0800)
committerKefu Chai <kchai@redhat.com>
Tue, 15 Dec 2020 09:15:17 +0000 (17:15 +0800)
first can be deduced by variable already captured, so store it as a
local variable. it's less expensive than storing it as a captured
variable.

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/crimson/osd/replicated_recovery_backend.cc

index b61ea19fd8fcafea7a194095595c52c19cd90003..efb2ab530a73833368bf1413c8c1edde9e41d797 100644 (file)
@@ -648,8 +648,8 @@ seastar::future<bool> ReplicatedRecoveryBackend::_handle_pull_response(
         return crimson::osd::PG::load_obc_ertr::now();
       }).handle_error(crimson::ct_error::assert_all{});
   };
-  return prepare_waiter.then([this, first=pi.recovery_progress.first,
-                             &pi, &pop, t, response]() mutable {
+  return prepare_waiter.then([this, &pi, &pop, t, response]() mutable {
+    const bool first = pi.recovery_progress.first;
     pi.recovery_progress = pop.after_progress;
     logger().debug("new recovery_info {}, new progress {}",
                   pi.recovery_info, pi.recovery_progress);