]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/cephadm: don't list non ceph daemons as needing upgrade in upgrade check 40893/head
authorAdam King <adking@redhat.com>
Fri, 16 Apr 2021 16:49:59 +0000 (12:49 -0400)
committerAdam King <adking@redhat.com>
Fri, 16 Apr 2021 16:49:59 +0000 (12:49 -0400)
Fixes: https://tracker.ceph.com/issues/50401
Signed-off-by: Adam King <adking@redhat.com>
src/pybind/mgr/cephadm/module.py

index c02602ec19b8ad9dfb660e958522a568e456e532..d06775e1023932c1cbf437b4e59e048b336f1865 100644 (file)
@@ -2283,17 +2283,20 @@ class CephadmOrchestrator(orchestrator.Orchestrator, MgrModule,
             'target_version': image_info.ceph_version,
             'needs_update': dict(),
             'up_to_date': list(),
+            'non_ceph_image_daemons': list()
         }
         for host, dm in self.cache.daemons.items():
             for name, dd in dm.items():
                 if image_info.image_id == dd.container_image_id:
                     r['up_to_date'].append(dd.name())
-                else:
+                elif dd.daemon_type in (CEPH_TYPES + GATEWAY_TYPES):
                     r['needs_update'][dd.name()] = {
                         'current_name': dd.container_image_name,
                         'current_id': dd.container_image_id,
                         'current_version': dd.version,
                     }
+                else:
+                    r['non_ceph_image_daemons'].append(dd.name())
         if self.use_repo_digest and image_info.repo_digests:
             # FIXME: we assume the first digest is the best one to use
             r['target_digest'] = image_info.repo_digests[0]