librados: Memory leaks in object_list_begin and object_list_end

We allocate a cursor in the constructor but simply reassign it in these
functions without cleaning up the original. We have a utility setter that
handles this exact case so we should use it.

Fixes: http://tracker.ceph.com/issues/18252
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
(cherry picked from commit 8d9d84bce923a009054ad2b223a97d7eb00e6774)

diff --git a/src/librados/librados.cc b/src/librados/librados.cc
index 05dfac509f712710513f5aaddc8452668caae07f..1dbb43fd16b35ca0be98bc8a647ffbb9aaccd2e6 100644 (file)
--- a/src/librados/librados.cc
+++ b/src/librados/librados.cc
@@ -5514,7 +5514,7 @@ librados::ObjectCursor librados::IoCtx::object_list_begin()
 {
   hobject_t *h = new hobject_t(io_ctx_impl->objecter->enumerate_objects_begin());
   ObjectCursor oc;
-  oc.c_cursor = (rados_object_list_cursor)h;
+  oc.set((rados_object_list_cursor)h);
   return oc;
 }
 
@@ -5523,7 +5523,7 @@ librados::ObjectCursor librados::IoCtx::object_list_end()
 {
   hobject_t *h = new hobject_t(io_ctx_impl->objecter->enumerate_objects_end());
   librados::ObjectCursor oc;
-  oc.c_cursor = (rados_object_list_cursor)h;
+  oc.set((rados_object_list_cursor)h);
   return oc;
 }