]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/common/fatal_signal: skip print_segv_info and proc_maps
authorMatan Breizman <mbreizma@redhat.com>
Wed, 4 Jun 2025 10:58:29 +0000 (10:58 +0000)
committerMatan Breizman <mbreizma@redhat.com>
Sun, 22 Jun 2025 09:08:36 +0000 (09:08 +0000)
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
src/crimson/common/fatal_signal.cc

index cab96c13891c95a6fa8c4719cc0ca26407437d1a..a5887f6de7b469551a87f97c5774458be6b5d21a 100644 (file)
@@ -110,7 +110,7 @@ void FatalSignal::install_oneshot_signal_handler()
   //       see handle_fatal_signal()
 }
 
-static void print_segv_info(const siginfo_t& siginfo)
+[[maybe_unused]] static void print_segv_info(const siginfo_t& siginfo)
 {
   std::cerr \
      << "Dump of siginfo:" << std::endl
@@ -139,7 +139,7 @@ static void print_segv_info(const siginfo_t& siginfo)
   std::cerr << std::flush;
 }
 
-static void print_proc_maps()
+[[maybe_unused]] static void print_proc_maps()
 {
   const int fd = ::open("/proc/self/maps", O_RDONLY);
   if (fd < 0) {
@@ -168,17 +168,20 @@ static void print_proc_maps()
 [[gnu::noinline]] void FatalSignal::signaled(const int signum,
                                              const siginfo_t& siginfo)
 {
+  // Commented out for clean backtrace logs,
+  // can be used if needed:
+  // print_proc_maps();
+  // print_segv_info(siginfo);
+
   switch (signum) {
   case SIGSEGV:
-    print_backtrace("Segmentation fault");
-    print_segv_info(siginfo);
+    print_backtrace("Got SIGSEGV");
     break;
   case SIGABRT:
-    print_backtrace("Aborting");
+    print_backtrace("Got SIGABRT");
     break;
   default:
-    print_backtrace(fmt::format("Signal {}", signum));
+    print_backtrace(fmt::format("Got signal {}", signum));
     break;
   }
-  print_proc_maps();
 }