]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mds,rgw: Initializing standby_reply, sync_tracer 19378/head
authoramitkuma <amitkuma@redhat.com>
Thu, 7 Dec 2017 15:49:58 +0000 (21:19 +0530)
committeramitkuma <amitkuma@redhat.com>
Thu, 7 Dec 2017 15:49:58 +0000 (21:19 +0530)
Fixes te coveity issue:

** 1396192 Uninitialized scalar field
CID 1396192 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member standby_replay is
not initialized in this constructor nor in any functions that it calls.

** 717382 Uninitialized pointer field
CID 717382 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member sync_tracer is not
initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com
src/mds/Beacon.h
src/rgw/rgw_rados.h

index 201804def072f593bc3dafaac4ede6b7aff9e4bc..8b5ac30b6f4de088a2584d9740b2e5f343a3d3bd 100644 (file)
@@ -87,7 +87,7 @@ private:
   mds_rank_t standby_for_rank;
   std::string standby_for_name;
   fs_cluster_id_t standby_for_fscid;
-  bool standby_replay;
+  bool standby_replay = false;
   MDSMap::DaemonState want_state;
 
   // Internal beacon state
index 97a62c65dd30d3002390ad459dc99d60c6f5a29a..ec1b4b6a1357cea545836ac91008c6b311474c89 100644 (file)
@@ -2285,7 +2285,7 @@ class RGWRados
   RGWMetaNotifier *meta_notifier;
   RGWDataNotifier *data_notifier;
   RGWMetaSyncProcessorThread *meta_sync_processor_thread;
-  RGWSyncTraceManager *sync_tracer;
+  RGWSyncTraceManager *sync_tracer = nullptr;
   map<string, RGWDataSyncProcessorThread *> data_sync_processor_threads;
 
   boost::optional<rgw::BucketTrimManager> bucket_trim;