]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
Merge pull request #55874 from adk3798/only-bind-to-network
authorAdam King <47704447+adk3798@users.noreply.github.com>
Tue, 19 Mar 2024 16:35:53 +0000 (12:35 -0400)
committerGitHub <noreply@github.com>
Tue, 19 Mar 2024 16:35:53 +0000 (12:35 -0400)
mgr/cephadm: allow grafana and prometheus to only bind to specific network

Reviewed-by: John Mulligan <jmulligan@redhat.com>
1  2 
src/cephadm/cephadmlib/daemons/monitoring.py
src/cephadm/tests/test_deploy.py
src/pybind/mgr/cephadm/module.py
src/pybind/mgr/cephadm/services/monitoring.py
src/pybind/mgr/cephadm/tests/test_services.py
src/python-common/ceph/deployment/service_spec.py

Simple merge
Simple merge
index 4f9102d1c1160621157ba06155595ff5ecf8f0c1,10ddcbbd02f056935fffd816c1b5d0393f906e25..184fb0251b82a15e97e3f69094aeacd3f2b284cf
@@@ -444,10 -431,15 +455,17 @@@ class PrometheusService(CephadmService)
              'haproxy_sd_url': haproxy_sd_url,
              'ceph_exporter_sd_url': ceph_exporter_sd_url,
              'nvmeof_sd_url': nvmeof_sd_url,
 +            'external_prometheus_targets': targets,
 +            'cluster_fsid': FSID
          }
  
+         ip_to_bind_to = ''
+         if spec.only_bind_port_on_networks and spec.networks:
+             assert daemon_spec.host is not None
+             ip_to_bind_to = self.mgr.get_first_matching_network_ip(daemon_spec.host, spec) or ''
+             if ip_to_bind_to:
+                 daemon_spec.port_ips = {str(port): ip_to_bind_to}
          web_context = {
              'prometheus_web_user': prometheus_user,
              'prometheus_web_password': password_hash(prometheus_password),