]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/osd: drop ObjectContext::loaded as it's never read.
authorRadoslaw Zarzynski <rzarzyns@redhat.com>
Mon, 15 Mar 2021 19:32:10 +0000 (19:32 +0000)
committerKefu Chai <kchai@redhat.com>
Fri, 2 Apr 2021 07:17:00 +0000 (15:17 +0800)
The `PG::with_obc*` machinery uses the `existed` marker
provided by the LRU cache subsystem.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
src/crimson/osd/object_context.h

index 251c8796b1dc2a6b520516c46bf8d2032e5a8c57..02d04cabe8c0654d5cd13e9336fdc42d703036eb 100644 (file)
@@ -43,14 +43,13 @@ public:
   Ref head; // Ref defined as part of ceph::common::intrusive_lru_base
   ObjectState obs;
   std::optional<SnapSet> ss;
-  bool loaded : 1;
   // the watch / notify machinery rather stays away from the hot and
   // frequented paths. std::map is used mostly because of developer's
   // convenience.
   using watch_key_t = std::pair<uint64_t, entity_name_t>;
   std::map<watch_key_t, seastar::shared_ptr<crimson::osd::Watch>> watchers;
 
-  ObjectContext(const hobject_t &hoid) : obs(hoid), loaded(false) {}
+  ObjectContext(const hobject_t &hoid) : obs(hoid) {}
 
   const hobject_t &get_oid() const {
     return obs.oi.soid;
@@ -74,14 +73,12 @@ public:
     ceph_assert(is_head());
     obs = std::move(_obs);
     ss = std::move(_ss);
-    loaded = true;
   }
 
   void set_clone_state(ObjectState &&_obs, Ref &&_head) {
     ceph_assert(!is_head());
     obs = std::move(_obs);
     head = _head;
-    loaded = true;
   }
 
   /// pass the provided exception to any waiting consumers of this ObjectContext